Skip to content

Updated to clarify what a checkpoint is and how to create it #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 7, 2025
Merged

Updated to clarify what a checkpoint is and how to create it #790

merged 9 commits into from
Mar 7, 2025

Conversation

stktung
Copy link
Contributor

@stktung stktung commented Feb 14, 2025

No description provided.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 17, 2025 •
edited
Loading

Deploying documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9cc57f9
Status: ✅  Deploy successful!
Preview URL: https://c6952cda.documentation-21k.pages.dev
Branch Preview URL: https://clarify-subscription-checkpo.documentation-21k.pages.dev

View logs

@stktung stktung marked this pull request as ready for review February 19, 2025 00:35
@coloradomorrissey coloradomorrissey requested review from Deflaimun and a team as code owners March 4, 2025 15:15
Deflaimun
Deflaimun reviewed Mar 4, 2025
View reviewed changes
Deflaimun
Deflaimun reviewed Mar 4, 2025
View reviewed changes
Deflaimun
Deflaimun reviewed Mar 4, 2025
View reviewed changes
Deflaimun
Deflaimun reviewed Mar 4, 2025
View reviewed changes
Deflaimun
Deflaimun reviewed Mar 4, 2025
View reviewed changes
Copy link
Contributor

@Deflaimun Deflaimun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey. Did a pass on these changes and left a couple comments. Let me know what you think.

Most of the suggested changes are considerations about the usage of active voice. Discard any that you don't think make sense.

@kurrent-io kurrent-io deleted a comment from Deflaimun Mar 7, 2025
@coloradomorrissey @Deflaimun
Update docs/clients/grpc/subscriptions.md
72b5a50 
Co-authored-by: Paulo Borges <paulohtb@hotmail.com>
@kurrent-io kurrent-io deleted a comment from Deflaimun Mar 7, 2025
@coloradomorrissey @Deflaimun
Update docs/clients/grpc/subscriptions.md
6528338 
Co-authored-by: Paulo Borges <paulohtb@hotmail.com>
@kurrent-io kurrent-io deleted a comment from Deflaimun Mar 7, 2025
@kurrent-io kurrent-io deleted a comment from Deflaimun Mar 7, 2025
coloradomorrissey and others added 2 commits March 6, 2025 19:56
@coloradomorrissey @Deflaimun
Update docs/clients/grpc/subscriptions.md
c60a51f 
Co-authored-by: Paulo Borges <paulohtb@hotmail.com>
@coloradomorrissey @Deflaimun
Update docs/clients/grpc/subscriptions.md
9cc57f9 
Co-authored-by: Paulo Borges <paulohtb@hotmail.com>
@kurrent-io kurrent-io deleted a comment from Deflaimun Mar 7, 2025
@coloradomorrissey coloradomorrissey merged commit 5aa7b1d into master Mar 7, 2025
2 checks passed
@coloradomorrissey coloradomorrissey deleted the clarify-subscription-checkpoint branch March 7, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coloradomorrissey coloradomorrissey coloradomorrissey approved these changes

@Deflaimun Deflaimun Awaiting requested review from Deflaimun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stktung @Deflaimun @coloradomorrissey